Reimplement Typecore.final_subexpression on Typedtree, not Parsetree#8775
Merged
nojb merged 3 commits intoocaml:trunkfrom Jul 2, 2019
Merged
Reimplement Typecore.final_subexpression on Typedtree, not Parsetree#8775nojb merged 3 commits intoocaml:trunkfrom
nojb merged 3 commits intoocaml:trunkfrom
Conversation
nojb
approved these changes
Jun 28, 2019
Contributor
nojb
left a comment
There was a problem hiding this comment.
Looks like a clear win to me, and with a test. LGTM!
Contributor
Author
|
Note: a similar operation to refine a warning's location is done in Typecore.check_partial_application, already at the Typedtree level (but not traversing exactly the same syntactic forms). |
stedolan
reviewed
Jul 1, 2019
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function is used to refine the location of warning 21
"this statement never returns (or has an unsound type.", e.g. to avoid pointing to an expression of the formlet ... = .... in e(but point toeinstead). In this PR: