Merged
Conversation
This should be improved to give better warnings for when Makefile.config and Makefile.common are required.
shindere
approved these changes
May 13, 2019
Contributor
|
This looks all very nice to me, many thanks and sorry for the delay for
reviewing. Beware that CI does not seem happy, but once this is either
fixed or understood, as far as I am ocncerned, feel free to merge.
|
Contributor
|
I am not merging yet because I don't know why Travis is failing, can anybody check this, please? |
Member
|
Travis is failing because (1) a The if [ -e CHECK_CONFIGURE ] ; then
rm -f CHECK_CONFIGURE
echo "configure or configure.ac altered in $1"
echo "Verifying that configure.ac generates configure"
git checkout "$1"
mv configure configure.ref
./autogen
if ! diff -q configure configure.ref >/dev/null ; then
echo "configure.ac no longer generates configure, \
please run ./autogen and commit"
exit 1
fi
fiThe relevant portion of the log is as follows: |
Member
|
(Apparently some of the |
Contributor
f36d63e to
a2ddf55
Compare
This was referenced Apr 20, 2020
This was referenced Jun 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The principal motivation for this change is to allow
make configureinstead of./autogen.