Windows Unicode support for ocamlyacc#8621
Conversation
stdlib.h is included in defs.h
Using an extern disables error checking of the parameters in "modern" compilers.
This deals with the command line processing only (i.e. filenames) - ocamlyacc continues to process .mly files as before.
fce7eea to
c066fb1
Compare
|
It was apparently a mistake to try to combine this PR with also eliminating |
c066fb1 to
3f6f6f1
Compare
nojb
left a comment
There was a problem hiding this comment.
I did a first pass. Two remarks:
-
It doesn't seem right to use the runtime headers when compiling
ocamlyacc. It makes the code less self-contained and I wonder how much work are we really saving. As far as I can tell, all we need is a bunch of_osmacros which could easily be added todefs.h. -
You support compiling both in Unicode and ANSI mode by switching
windows_unicode_enabled. Is there any reason for this? If not, I would just compile for Unicode unconditionally.
|
@nojb - ocamlyacc was already using the runtime headers, except that before there was duplication between what was in |
|
I don't have a strong opinion either way on |
3f6f6f1 to
7482ff4
Compare
damiendoligez
left a comment
There was a problem hiding this comment.
Looks OK to me, you may want to get a nod from @nojb before merging.
|
Oups! Very sorry I completely forgot about this one. Yes, I had a few slight questions/remarks about the PR but was convinced by @dra27 answers, so I'm approving as well :) |
7482ff4 to
7f96c82
Compare
This is part of #1200 which didn't make the merge window for 4.06.0.
The motivation behind this is the elimination of
MKEXE_ANSI, the presence of which is hurting some work I'm trying to do both extending the FlexDLL bootstrap to the Cygwin ports and extendingconfigure's detection support for FlexDLL/flexlink.This PR does not alter the way .mly files are interpreted, rather it permits
ocamlyaccto receive names on the command line which include extended characters. For the most part this is irrelevant, since most resulting names won't be valid module names.