Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
.annotfiles to be done from.cmtfiles (for this, it integrates the existing code fromtools/cmt2annot.ml+ a couple of bug fixes).Stypesfrom the typechecker.-annot.The generated
.annotfiles with the new approach are not identical, but the diff appears harmless. See e.g. the diff for the compiler codebase:https://gist.github.com/nojb/2ce3a3c99bf3c587b0c8edd7430c6b37
One small regression is that the "old" code also recorded, when compiling bytecode, whether function calls where in tail position or not. As far as I can see, this is not done in the new code.