handle -stop-after parsing when processing .mli files#2032
Merged
gasche merged 2 commits intoocaml:trunkfrom Sep 8, 2018
Merged
handle -stop-after parsing when processing .mli files#2032gasche merged 2 commits intoocaml:trunkfrom
-stop-after parsing when processing .mli files#2032gasche merged 2 commits intoocaml:trunkfrom
Conversation
154b50d to
ef75388
Compare
nojb
approved these changes
Sep 8, 2018
Contributor
nojb
left a comment
There was a problem hiding this comment.
Good to merge if CI passes.
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is arguably a bug in the original implementation: only
Compiler_common.implementationwas made to support-stop-after parsing, notCompiler_common.interface.This PR also adds a testsuite for
stop-afteroptions intestsuite/tests/tool-ocamlc-stop-after.