parser.mly: consistently use $sloc over $loc#2031
Merged
gasche merged 1 commit intoocaml:trunkfrom Sep 8, 2018
Merged
Conversation
Menhir has two keywords to describe "the current source position", $loc and $sloc. $sloc is more precise (it is included within $loc), and the two differ only when the production starts with empty symbols, and the difference only spans over whitespace. We originally used $loc by default to emulate ocamlyacc behavior, but $sloc is generally preferable, so this PR converts all locations to use $sloc. (Note: the location-of-a-symbol keyword remains $loc(...), for example $loc($1) or $loc(foo), there is no $sloc version of those.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Menhir has two keywords to describe "the current source position",
$loc and $sloc. $sloc is more precise (it is included within $loc),
and the two differ only when the production starts with empty symbols,
and the difference only spans over whitespace.
We originally used $loc by default to emulate ocamlyacc behavior,
but $sloc is generally preferable, so this PR converts all locations
to use $sloc.
(Note: the location-of-a-symbol keyword remains $loc(...), for example
$loc($1) or $loc(foo), there is no $sloc version of those.)
I have tested this PR using #2030, and it does not, in fact, change any parse location in the compiler distribution. On the contrary, the converse change (turning all $sloc into $loc) produces a lot of location changes, as expected.
This proposed change was mentioned/discussed in #2029 and, more importantly, in #2016 (comment).