Skip to content

ocamldoc: expand support for "include module type of"#2000

Merged
2 commits merged intoocaml:trunkfrom
Octachron:ocamldoc_include_module_type_of
Aug 22, 2018
Merged

ocamldoc: expand support for "include module type of"#2000
2 commits merged intoocaml:trunkfrom
Octachron:ocamldoc_include_module_type_of

Conversation

@Octachron
Copy link
Copy Markdown
Member

This PR extends the adhoc support in ocamldoc for

include module type of M

to also include the expanded version

include module type of struct include M end

See #1605 for an use case.

Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an ocamldoc expert, however the change looks straightforward and the resulting html looks correct.

@ghost
Copy link
Copy Markdown

ghost commented Aug 22, 2018

@Octachron I think we can merge this after adding a changelog entry

@Octachron Octachron force-pushed the ocamldoc_include_module_type_of branch from 60c7bca to 644927f Compare August 22, 2018 15:13
@ghost ghost merged commit 070541b into ocaml:trunk Aug 22, 2018
@nojb nojb mentioned this pull request Aug 23, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant