Remove the unreachable Typecore.Recursive_local_constraint error#1868
Merged
damiendoligez merged 1 commit intoocaml:trunkfrom Jun 29, 2018
Merged
Conversation
Typecore.Recursive_local_constraints errorTypecore.Recursive_local_constraint error
trefis
approved these changes
Jun 29, 2018
Contributor
trefis
left a comment
There was a problem hiding this comment.
Travis is happy, which is good enough for me.
At some point in the not too distant future I plan to turn on a bunch of warnings and submit a (potentially huge?) PR fixing all such issues. But you're welcome to start without me! :)
Contributor
|
Thomas Refis (2018/06/28 23:36 -0700):
At some point in the not too distant future I plan to turn on a bunch
of warnings and submit a (potentially huge?) PR fixing all such
issues. But you're welcome to start without me! :)
That'd be great!
In particular, I am not sure all the OCaml files are compiled with
exactly the same set of warnings enabled and would find this nice to
have the same flags used through all the build system, if possible.
|
Member
|
Thanks for the cleanup! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Ctype.Recursive_abbrevexception is no longer raised in the compiler. This PR removes it along with theTypecore.Recursive_local_constraintserror which was no longer reachable.