make install: remove old files to account for new packed stdlib#1724
Merged
nojb merged 1 commit intoocaml:trunkfrom Apr 16, 2018
Merged
make install: remove old files to account for new packed stdlib#1724nojb merged 1 commit intoocaml:trunkfrom
nojb merged 1 commit intoocaml:trunkfrom
Conversation
ghost
reviewed
Apr 16, 2018
stdlib/Makefile
Outdated
| install:: | ||
| # Transitional: when upgrading from 4.06 -> 4.07, module M is in stdlib__m.cm*, while previously | ||
| # it was in m.cm*, which confuses the compiler. Also, pervasives.* is now stdlib.*. | ||
| rm -f $(patsubst stdlib__%,"$(INSTALL_LIBDIR)/%", $(filter stdlib__%,$(wildcard *.cm*))) |
There was a problem hiding this comment.
Why not $(OBJS) rather than $(wildcard *.cm*)? If you run make world.opt install for instance, I'm not entirely sure $(wildcard *.cm*) will be interpreted as expected
Contributor
Author
There was a problem hiding this comment.
Indeed, using $(OBJS) is much better. Fixed.
ghost
approved these changes
Apr 16, 2018
507e903 to
7373f56
Compare
Contributor
Author
|
This is d231743 in 4.07. |
Contributor
Author
|
I think we should also delete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See MPR#7773. The module
Mfrom the standard library is now contained in modules calledstdlib__m.cm*, so they do not override the "old" modulesm.cm*, which confuses the compiler. Similarly,pervasivesis not overwritten by the newstdlib.So let's erase the old files when doing
make installto avoid any conflict.