Skip to content

Add Float.pi#1674

Merged
nojb merged 1 commit intoocaml:trunkfrom
Chris00:pi
Mar 29, 2018
Merged

Add Float.pi#1674
nojb merged 1 commit intoocaml:trunkfrom
Chris00:pi

Conversation

@Chris00
Copy link
Copy Markdown
Member

@Chris00 Chris00 commented Mar 21, 2018

@Chris00 Chris00 mentioned this pull request Mar 21, 2018
@Chris00 Chris00 force-pushed the pi branch 2 times, most recently from 9715c4c to f22d847 Compare March 23, 2018 18:27
Copy link
Copy Markdown
Member

@damiendoligez damiendoligez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the value against http://piday.org/million and https://en.wikipedia.org/wiki/Pi, it's very probably the right one.

@nojb
Copy link
Copy Markdown
Contributor

nojb commented Mar 29, 2018

@Chris00 If you can add Damiel Doligez as a reviewer in the Changes file, we can merge this.

@Chris00
Copy link
Copy Markdown
Member Author

Chris00 commented Mar 29, 2018

Done.

@nojb nojb merged commit 2197ec6 into ocaml:trunk Mar 29, 2018
@nojb
Copy link
Copy Markdown
Contributor

nojb commented Mar 29, 2018

Thanks!

@Chris00 Chris00 deleted the pi branch March 29, 2018 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants