Merged
Conversation
Member
|
It is slightly irritating that the list of architectures that are known to sometimes cause a segfault is maintained twice in two different places. Could this be factorized with a helper somehow? |
Member
Author
|
It’s not the same list - one is the list of architectures which may ever segfault on anything, the other is a list of architectures which may segfault on a specific test. While it would be good if we finally moved away from using strings for these things, the lists’ having the same elements is just coincidence. FWIW, I’m expecting to remove the shim completely, but it needs a precheck worker upgrade |
gasche
approved these changes
Mar 2, 2026
Contributor
|
Cherry-pick to 5.5 880c274 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit got blown away in #14547 (comment).