ocamltest negation: not <action>;#14502
Merged
gasche merged 7 commits intoocaml:trunkfrom Jan 30, 2026
Merged
Conversation
Closed
OlivierNicole
approved these changes
Jan 30, 2026
Contributor
OlivierNicole
left a comment
There was a problem hiding this comment.
This looks good to me! :-)
5aac6fb to
71d3bc3
Compare
This was referenced Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not <action>;performs<action>, passes if it skips and skips if it passes. This is intended to be used for predicate-like action which have no other observable behavior than passing or skipping. For example,not msvc;is equivalent tonot-msvc;, and in fact that PR removes the latter action.(This PR updates existing tests to use
not, it removes all actions that are obviously the negative of something that is more natural to define, except fornot_macos_amd64_tsanwhich would require conjunction andnot-rootwhich I felt like leaving alone.)