Merged
Conversation
The new_predef_types hack breaks type-directed disambiguation of iarray annotations (by shadowing `iarray` from the stdlib), so iarray.ml cannot actually build with this extra type definition.
dune build the whole stdlib with -nolabels
dune build the whole stdlib with -nolabels
46fd16c to
7497dce
Compare
Octachron
approved these changes
Oct 30, 2025
Member
Octachron
left a comment
There was a problem hiding this comment.
Here is my token approval, but I will let you merge once you are happy with the patch.
Member
Author
|
Thanks! The force-push was just to get check-typo happy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.