[minor] use a record in Compenv.process_deferred_actions#14026
Merged
gasche merged 1 commit intoocaml:trunkfrom May 14, 2025
Merged
[minor] use a record in Compenv.process_deferred_actions#14026gasche merged 1 commit intoocaml:trunkfrom
gasche merged 1 commit intoocaml:trunkfrom
Conversation
nojb
approved these changes
May 12, 2025
Contributor
nojb
left a comment
There was a problem hiding this comment.
LGTM
I left a few comments, but they are purely optional.
Comment on lines
+633
to
+638
| log : Format.formatter; | ||
| compile_implementation: | ||
| start_from:Clflags.Compiler_pass.t -> | ||
| source_file:string -> output_prefix:string -> unit; | ||
| compile_interface: | ||
| source_file:string -> output_prefix:string -> unit; |
Contributor
There was a problem hiding this comment.
I would have called these fields ppf, implementation, and interface which are the names used everywhere else for them, but up to you.
Contributor
|
@gasche check-typo needs to be satisfied; then feel free to merge if you are happy with the state of the PR. |
a4fc12a to
b8a7fa1
Compare
Reviewed-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
b8a7fa1 to
e83af50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to look at #13766 again, and one of the changes touches a tuple type in Compenv that has a documentation comment for each component. This is a case where using a record makes things clearer, so I went to use that instead.