Document [row_more] and [row_fixed].#14023
Conversation
|
(It looks like this issue attracts automated spammers for some reasons. Unfortunately I have no better idea than to delete spam comments after they have been posted, so I'm doing just that.) |
|
@garrigue can you confirm that what's written is not factually wrong? I can take the rest of the review from that assessment, or just merge. |
garrigue
left a comment
There was a problem hiding this comment.
Looks essentially correct, except for the Tnil case.
For historical reasons, I do not think we rely on Tnil being set correctly, but it is better to have new code comply.
There is also a bit of nitpicking about the distinction between structural and physical equality; unfortunately in ocaml physical equality is observable, which makes discussions about equality more complex.
gasche
left a comment
There was a problem hiding this comment.
I didn't review this in-depth myself, but I'm all for better documentation of the internals, so I approve based on @garrigue's review and my trust in @goldfirere's fixes/updates.
As discussed earlier this week. Review request from @garrigue (or perhaps @gasche).