Pprintast: use parentheses around Pexp_struct_item in sequences#14008
Merged
gasche merged 3 commits intoocaml:trunkfrom May 2, 2025
Merged
Pprintast: use parentheses around Pexp_struct_item in sequences#14008gasche merged 3 commits intoocaml:trunkfrom
gasche merged 3 commits intoocaml:trunkfrom
Conversation
Member
|
We are looking at a bug that was facilitated by a catch-all pattern in a function that should be revisited on each new expression-former. I wish you would remove the catch-all pattern and replace it by a fixed list of cases. |
Contributor
Author
I can get rid of the catch-all pattern, but note that it wouldn't have helped with this bug because the case that was missing an adaptation is guarded by a |
gasche
approved these changes
May 2, 2025
Member
|
I had missed the subtlety on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small bug fix following #13839: the treatment in
Pprintastfor the newPexp_struct_itemneeds to be equivalent toPexp_letin order to add parentheses correctly when these expressions appear in sequences.