Skip to content

GHA: add a Cygwin x86_64 job, triggered by the run-cygwin-tests label#13996

Closed
MisterDA wants to merge 5 commits intoocaml:trunkfrom
MisterDA:gha-cygwin
Closed

GHA: add a Cygwin x86_64 job, triggered by the run-cygwin-tests label#13996
MisterDA wants to merge 5 commits intoocaml:trunkfrom
MisterDA:gha-cygwin

Conversation

@MisterDA
Copy link
Copy Markdown
Contributor

I hope this could help us tackle specific Cygwin problems from time to time, when they emerge. I've protected the Cygwin tests under the run-cygwin-tests, as the tests take a long time to execute. GNU parallel isn't available in the Cygwin package repository. It is available on MSYS2. I successfully installed it locally, but its install script failed in CI.

Please consider creating the run-cygwin-tests label and setting it on this PR.

cc @kit-ty-kate @dra27

[make_unreadable] doesn't work on Cygwin with noacl as the read
permission cannot be removed. The runtime event lib only need the read
perm to open the backing file.
@gasche gasche added the CI: Full matrix Makes the CI test a bigger set of configurations label Apr 28, 2025
@gasche
Copy link
Copy Markdown
Member

gasche commented Apr 28, 2025

Please consider creating the run-cygwin-tests label and setting it on this PR.

Done! Note that we have a bad track record with this kind of labels, triagers/maintainers typically forget to use them even when it would be useful.

(Are they documented somewhere in HACKING.adoc? They should.)

@MisterDA
Copy link
Copy Markdown
Contributor Author

Done! Note that we have a bad track record with this kind of labels, triagers/maintainers typically forget to use them even when it would be useful.

…but on the other hand 50 minutes of CI by default is too much to ask of anyone!

@dra27
Copy link
Copy Markdown
Member

dra27 commented Apr 28, 2025

We might want to merge this with parts of dra27#195 - I've been doing Cygwin testing with GitHub Actions for a little while for Relocatable OCaml, but I opted to fix ocamltest rather than disable test_create_cursor_failures.ml. The main thing is that I was intending to propose adding a more general "CI: Full matrix" label.

@MisterDA MisterDA marked this pull request as draft April 29, 2025 09:29
@MisterDA MisterDA closed this May 4, 2025
@MisterDA MisterDA deleted the gha-cygwin branch May 7, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: Full matrix Makes the CI test a bigger set of configurations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants