Merged
Conversation
050c14c to
3998510
Compare
3998510 to
bdb9780
Compare
nojb
approved these changes
Dec 23, 2024
Contributor
nojb
left a comment
There was a problem hiding this comment.
LGTM, modulo small issue below
A second approval is needed before the PR can be merged.
yallop
approved these changes
Dec 23, 2024
Member
yallop
left a comment
There was a problem hiding this comment.
Approved, but with a few small changes proposed.
Contributor
Author
Member
|
Yes, I'm happy with the latest revision |
Contributor
|
Merged. Thanks @dbuenzli! |
Contributor
Author
|
Thanks to both! That felt such an easy ride that I felt compelled to open #13696 to suffer a bit :–) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First this PR adds a few doc cleanups and clarifications to
char.mlibest read commit by commit. Second it adds anChar.Asciimodule to deal with ASCII data.A rendering of resulting docs for the module can be found here.
As already mentioned before, functions working on ASCII-only remain useful on a wide variety of tasks because they also work on UTF-8 encoded strings and lots of data munging tasks do operate on the ASCII subset of UTF-8.
Predicate definitions
The definitions of predicates are taken from the C standard library in the default
"C"locale. More precisely the following definitions are used:Char.Asciiis_upperisupperis_lowerisloweris_letterisalphais_alphanumisalnumis_whiteisspaceis_blankisblankis_graphicisgraphis_printisprintis_controliscntrlis_digitisdigitis_hex_digitisxdigitCloses #13657