[refactor] split constructor/fields types from Types to Data_types#13466
[refactor] split constructor/fields types from Types to Data_types#13466gasche merged 3 commits intoocaml:trunkfrom
Conversation
6d83610 to
521f9a0
Compare
|
Should the new module name be Overall, I agree that detaching this module from
I would propose to move the two functions of Similarly, I would rather avoid opening the full module in the mli for |
|
I applied your recommendations and rebased. Changes:
I prefer Data_types to Datatypes, because I can see a use for other Foo_types module, for example my in-progress PR has a Head_shape_types module, and Headshapetypes would be ugly. We could change Datadescr into something else, in time (never). |
Octachron
left a comment
There was a problem hiding this comment.
The change looks fine to me.
|
Thanks! I will fix the typos, massage the history (removing the opens could go in the first commit), merge, and rebase #13467. |
One must be careful about changing typing/Types, because (some of) the types it defines are used in .cmi files, so any change to those requires a delicate bootstrap and magic number bump. This refactoring splits off a part of Types that is *not* used in .cmi files -- information about record fields and variant constructors. They move to a new typing/Data_types compilation unit, which can evolve more freely.
Suggested-by: Florian Angeletti <florian.angeletti@inria.fr>
Suggested-by: Florian Angeletti <florian.angeletti@inria.fr>
One must be careful about changing typing/Types, because (some of) the types it defined are used in .cmi files, so any change to those requires a delicate bootstrap and magic number bump.
This refactoring splits off a part of Types that is not used in .cmi files -- information about record fields and variant constructors. They move to a new typing/Data_types compilation unit, which can evolve more freely.