testsuite: a test case for a pessimization from 13076#13337
Merged
gasche merged 2 commits intoocaml:trunkfrom Jul 31, 2024
Merged
testsuite: a test case for a pessimization from 13076#13337gasche merged 2 commits intoocaml:trunkfrom
gasche merged 2 commits intoocaml:trunkfrom
Conversation
Contributor
|
(I happen to have been reading through the linked PR and saw this, hence the immediate response.) This indeed looks like a proper regression test. I would click "Approve" if I could. |
Member
Author
|
I added the two extra test cases proposed by @ncik-roberts in #13076 (comment) . |
ncik-roberts
approved these changes
Jul 31, 2024
Member
Author
|
This needs approval from a maintainer to move forward. |
yallop
approved these changes
Jul 31, 2024
Member
yallop
left a comment
There was a problem hiding this comment.
Approving on behalf of @ncik-roberts (but it looks sensible to me, too).
Member
Author
|
Thanks! Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#13076, part of The Pattern-Matching Bug PR series and already merged, introduced a small regression / pessimization -- some pattern-matching programs generate slightly worse code than before. I will be working on a fix, but a good first step is to introduce a testcase for the issue -- which would help reviewing a fix, and can serve as a regression test later.