restore caml_process_pending_actions_exn #13304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadmm
approved these changes
Jul 16, 2024
Contributor
gadmm
left a comment
There was a problem hiding this comment.
I don't see the need for a helper function caml_result_get_encoded_exception. I'd rather see it inlined in the function. But it's up to you.
I made a mistake when introducing caml_process_pending_actions_res (ocaml#13013), currently in trunk `caml_process_pending_actions_exn` is exported in signals.h but its implementation is removed. This function is not CAML_INTERNALS, and Coq uses it. To restore this function I reintroduced a helper function to transform `caml_result` values back into encoded exception (earlier ocaml#13013 designs had this). It is named `caml_result_get_encoded_exception`, in fail.h, CAML_INTERNALS-only.
3b36e72 to
65eaf62
Compare
Member
Author
|
This needs a maintainer approach, maybe @Octachron? |
Octachron
reviewed
Jul 18, 2024
| #ifdef CAML_INTERNALS | ||
| // internals only, provided for backward-compatibility | ||
| Caml_inline value caml_result_get_encoded_exception( | ||
| struct caml_result_private result) |
Member
There was a problem hiding this comment.
Is this function supposed to be part of the puvlic API of caml_result?
Member
Author
There was a problem hiding this comment.
No, it is CAML_INTERNALS only. It is only useful in transition scenarios, but I suspect that we may want to use it in more parts of the runtime occasionally (which is why factored it out of caml_process_pending_actions_exn).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a mistake when introducing
caml_process_pending_actions_res(#13013), currently in trunkcaml_process_pending_actions_exnis exported in signals.h but its implementation is removed.This function is not CAML_INTERNALS, and Coq uses it.
To restore this function I reintroduced a helper function to transform
caml_resultvalues back into encoded exception (earlier #13013 designs had this). It is namedcaml_result_get_encoded_exception, in fail.h, CAML_INTERNALS-only.