Use another variable to pass CFLAGS/CPPFLAGS to user OCaml code#12975
Closed
purplearmadillo77 wants to merge 1 commit intoocaml:trunkfrom
Closed
Use another variable to pass CFLAGS/CPPFLAGS to user OCaml code#12975purplearmadillo77 wants to merge 1 commit intoocaml:trunkfrom
purplearmadillo77 wants to merge 1 commit intoocaml:trunkfrom
Conversation
Instead, can pass flags at configure time through PASS_THRU_CFLAGS and PASS_THRU_CPPFLAGS
11d37f7 to
3f011c4
Compare
Contributor
|
Many thanks for your proposal! I believe that the original issue is addressed in a more principled way by |
Contributor
Author
|
Thank you! Will give it a try - response in #12589. |
Member
|
#12589 has been merged in favour of this approach - thanks for the report, testing on the other PR and for this alternate approach! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took a stab at not passing
CFLAGSinto all user compiled code (#12578, #12589) while keeping most of the current mechanism intact in new environment variablesPASS_THRU_CFLAGSandPASS_THRU_CPPFLAGS.This allows one to call
./configure PASS_THRU_CFLAGS=-Duseful_macroand pass those flags onto user commands such asocamlc hello.c.I wasn't sure what linker flag features were desired so I left those alone for now.