Refactor caml_c_thread_(un)register to fix various bugs#12834
Merged
gasche merged 11 commits intoocaml:trunkfrom Jan 12, 2024
Merged
Refactor caml_c_thread_(un)register to fix various bugs#12834gasche merged 11 commits intoocaml:trunkfrom
gasche merged 11 commits intoocaml:trunkfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another systhread rabbit-hole:
caml_c_thread_(un)register. In order to make it better understandable, I refactored it in order to share code with thread_new, thread_start and thread_stop. Differences between thread_new+thread_start and c_thread_register are subtle and come down to when is the GC available to allocate the thread descriptor.We could share even more code if we change a few details, I can share some idea if someone has the time to implement it.I think several bugs are fixed by this refactor:
save_runtime_statelogic incaml_thread_yield#12830)memprof_delete_threads