Make the unerasable optional argument warning stricter to enforce semantics#12739
Open
garrigue wants to merge 6 commits intoocaml:trunkfrom
Open
Make the unerasable optional argument warning stricter to enforce semantics#12739garrigue wants to merge 6 commits intoocaml:trunkfrom
garrigue wants to merge 6 commits intoocaml:trunkfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #10653, the current compilation scheme only preserves the strict-eager semantics of partial application if all optional arguments are followed by an unlabeled one in the same n-ary abstraction.
This PR modifies warning 16 to enforce this.
It will trigger for lablgtk, and maybe some other libraries which make un-orthodox use of optional arguments, but it clarifies the semantics.
Only merge after discussion.