Merged
Conversation
70ee2c4 to
84e4d47
Compare
gasche
approved these changes
Jul 25, 2023
Member
gasche
left a comment
There was a problem hiding this comment.
I reviewed the previous PR and didn't find any bug. I reviewed the present PR and don't find any bug either, so it is natural to go ahead and merge.
Member
|
I think it'd be nice to add the PR number to the existing Changes entry for #12315. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#12315 introduced a bug in the typing of
let rec, causing recursive functions with optional parameters that have defaults to no longer typecheck.The issue is that the typing of patterns on optional parameters is slightly different depending on whether a default is present:
In both cases, the type is
?x:int -> unit -> unit, represented internally as something like this:The type in the function arrow is internally always
int option, but the type of the pattern should beint optiononly when there is no default, andintif there is a default.#12315 always typechecked like
f, causing type errors on code with defaults. (Since the change was totype_approx, this only affects such functions when they are part of a recursive group).