fix bad behaviour of caml_alloc_custom_mem (4.14)#12322
Open
damiendoligez wants to merge 1 commit intoocaml:4.14from
Open
fix bad behaviour of caml_alloc_custom_mem (4.14)#12322damiendoligez wants to merge 1 commit intoocaml:4.14from
caml_alloc_custom_mem (4.14)#12322damiendoligez wants to merge 1 commit intoocaml:4.14from
Conversation
caml_alloc_custom_mem (4.14)
7379958 to
4aa224d
Compare
4aa224d to
5d1e983
Compare
Member
|
The code looks fine to me. The question is whether the benefits of fixing bad behaviors on 4.14 is worth the risk of fixing accidentally-desirable behaviors in 4.14. I think we should try on a Bigarray program to reassure ourselves before making a merge decision. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the backport of #12318 to 4.14.