Allow make promote-menhir from Windows#12308
Merged
dra27 merged 1 commit intoocaml:trunkfrom Jun 17, 2023
Merged
Conversation
gasche
approved these changes
Jun 16, 2023
Member
gasche
left a comment
There was a problem hiding this comment.
Okay, okay. As long as it keeps working on Linux, these small-scale horrors are just fine.
Member
|
The CI fails on the "extra (debug)" configuration, with the following failure for the test This is clearly unrelated to the present PR, but also probably a bug. I wonder who could be interested in looking at this. Maybe @NickBarnes? |
Member
Author
Member
Author
I may start haggling on the definition of “small-scale” at some point! 🙂 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the occasions in the past when I've had to run
make promote-menhirI've clearly been lazy and done it from Linux 😉There were two problems which are fixed here:
menhir --suggest-menhirLibreturns a CRLF string on Windows, and the\rwas causing problems. The best fix is to use$(shellinstead of backticks, both because it stops menhir being called twice and also because$(shell) automatically strips the line endings.--ocamlcneeds to be passed a Windows path (i.e. with backslashes) because it gets passed toSys.command. The necessary machinery is added to convert the slashes when running from Windows.