Merge debugger/Makefile into the root Makefile#12198
Conversation
5497950 to
4a19f99
Compare
52c235e to
906eb6c
Compare
|
Note that, to be consistent with the rest of the build system, this PR Also, the debugger's dependencies are computed in |
dc48720 to
836ef17
Compare
If symlinks are used, they need to be native-Windows compatible ones. Ensure that the CYGWIN and MSYS environment variables use the winsymlinks:nativestrict option, which causes symlink(2) to fail if NTFS symlinks are not available. In this case, config.status will then fall-back to hardlinks or copying.
…ystem More precisely, this commit makes use of the following additional flags when compiling the debugger: -g -principal -bin-annot. The warning 70 about missing interfaces is re-enabled for the debugger, which leads to the addition of two interface files.
|
This branch now starts with two commits that may seem unrelated but here is On trunk, On the PR branch, the order enforced on trunk is no longer enforced so that Although it would be possible to impose an ordering on the computation of That's what the first commit of this PR does, using the The subsequent commit, authored by @dra27 and reviewed by me, makes sure |
|
One other thing to note is that, in its present state, this PR compiles the |
fa33f9a to
e0cf8c7
Compare
So far, program targets could only accept object files to be linked into the built program as their prerequisites. This was so because the recipes were using $^ as the list of object files to link, meaning all the prerequisites. With this commit, it becomes possible to have prerequisites that do need to be build before the target is built but without necessarily being linked into the target. This is implemented by defining target-specific variables foo_BCOBJS and foo_NCOBJS containing the list of associated object files. These variables are then used in the recipes, meaning that the targets can now take additional prerequisites which won't appear in the recipes.
43e5206 to
9e0d87f
Compare
9e0d87f to
aad7f97
Compare
dra27
left a comment
There was a problem hiding this comment.
Another one bites the dust! The force push history and logs record the offline reviewing which has taken place. This is the first of the merges where the artefacts are all built using the root compiler (i.e. ./ocamlc rather than boot/ocamlc), and so also the first time Makefile.best_binaries gets pulled into the root Makefile. This has been through precheck#832.
|
Many thanks to David for his review comments which were, as always, both
incredibly valuable andincredibly supportive. To the point where it
feels he deserves authorship even more than I do.
|
This continues the work started in #11243, #11248, #11268, #11420 and #11675.