Closed
Conversation
Co-authored-by: Stephen Dolan <sdolan@janestreet.com>
34 tasks
Member
Author
|
This PR is the result of a side-channel discussion with @stedolan - it just documents the current state, which should be fine for 5.0. A separate issue can be opened if wanted to track investigating improvements to it. |
Contributor
|
If this hash function was a known design described and evaluated in the literature, a comment pointing to the description and evaluation would be useful. A comment that just says "we picked this function on a whim and have no idea how well it works" is not useful, so I'll close this PR. I make a mental note to replace this code by a well-known hash function soon (but not in 5.0). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a comment from the multicore merge in #10861.
It may be possible/desirable to improve on this in a future release.