[3/3] Restructure LIBDIR: Move the Profiling module to a sub-directory#11200
Merged
shindere merged 1 commit intoocaml:trunkfrom May 9, 2022
Merged
[3/3] Restructure LIBDIR: Move the Profiling module to a sub-directory#11200shindere merged 1 commit intoocaml:trunkfrom
shindere merged 1 commit intoocaml:trunkfrom
Conversation
Contributor
|
Thanks for that bit, too! Have you considered factorizing the the profiling-lelated flags which are |
ocamlcp and ocamloptp specify -I +profiling
115ab57 to
a805f1f
Compare
Member
Author
|
Thanks, @shindere! I hadn't considered unifying them (certainly not as part of this), although if you like the look of dra27@3056ab0 then I can open a PR for it! |
shindere
approved these changes
May 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the third PR in a series starting with #11198 which seek to separate the components in OCaml's
$LIBDIR.The profiling versions of the compiler (
ocamlcpandocamloptp) require a runtime moduleProfilingwhich is installed in$LIBDIRand therefore at present visible all the time. This PR movesprofiling.*from$LIBDIRto$LIBDIR/profilingand updates the two tools to add-I +profilingto the command line. It remains the case that the user must avoid using a module calledProfilingif they wish to useocamlprof, but the already quite slim chance of inadvertently referring toProfilingwithout linking with it is now reduced to zero.Note that this PR actually hardens the use of
Profilingwithinocamlprof, as using-I +profilingas the first-Idirectory ensures thatProfilingalways refers toocamlprof's module.