Minor improvements to "named values" handling#11056
Merged
xavierleroy merged 3 commits intoocaml:trunkfrom Feb 24, 2022
Merged
Conversation
The function is currently unused. But taking `named_value_lock` during iteration feels safer.
It's the same algorithm we had before, only with better constants.
dra27
reviewed
Feb 24, 2022
Member
dra27
left a comment
There was a problem hiding this comment.
LGTM - otherlibs/win32unix/unixsupport.c hadn't diverged in the same way, but please could the atomic access to the cache be copied over?
Like in OCaml 4, but with atomic accesses on the cache.
c17f75c to
a6d0b76
Compare
Contributor
Author
|
Well spotted! I updated otherlibs/win32unix/unixsupport.c as well. |
dra27
approved these changes
Feb 24, 2022
Member
dra27
left a comment
There was a problem hiding this comment.
Up to you whether the tweak to the hash warrants a Changes entry - it's pretty internal (and the manual of course recommends caching caml_named_value results as well)
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three commits that address some of the outstanding review comments (#10861):