Skip to content

Flambda testsuite fixes, continued#10912

Merged
gasche merged 1 commit intoocaml:trunkfrom
lthls:multicore-flambda-testsuite-fixes-bis
Jan 17, 2022
Merged

Flambda testsuite fixes, continued#10912
gasche merged 1 commit intoocaml:trunkfrom
lthls:multicore-flambda-testsuite-fixes-bis

Conversation

@lthls
Copy link
Copy Markdown
Contributor

@lthls lthls commented Jan 17, 2022

This is a follow-up to PR #10909, fixing the test for warning 59 and one backtrace output.


* flambda
compiler_reference = "${test_source_directory}/w59.flambda.reference"
flags = "-w +A-70 -dflambda-invariants"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: we now have a technique to avoid having to change reference line numbers when we edit the test block, which is to use the TEST_BELOW feature to have the test block at the end (see backtrace/backtrace.ml). Of course if you decide to move to that you have to change the line numbers anyway, but hopefully for the last time.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't think about that. Do you think it would be a good idea to make a big PR changing all tests that check line numbers at once ? Or just switch individual tests when we need to fix line numbers ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go the incremental route, and focus only on tests whose reference output contains line numbers. You had to touch a good number of those in your fixing-flambda work, maybe you want to change them all those at once.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, all tests involving backtraces or compiler warnings will likely be concerned, so a global sweep of the corresponding directories would make sense too. The incremental approach still makes sense for the rest of the tests.

@gasche gasche merged commit 310541f into ocaml:trunk Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants