Remove Stream, Genlex, Pervasives & the legacy bigarray library#10896
Remove Stream, Genlex, Pervasives & the legacy bigarray library#10896nojb merged 6 commits intoocaml:trunkfrom
Stream, Genlex, Pervasives & the legacy bigarray library#10896Conversation
| AC_ARG_ENABLE([bigarray-lib], | ||
| [AS_HELP_STRING([--disable-bigarray-lib], | ||
| [do not build the legacy separate bigarray library])]) |
There was a problem hiding this comment.
I believe you might be asked to keep the option around and make it error gracefully instead.
e.g. #10893 (comment)
7f3a53d to
08c2111
Compare
avsm
left a comment
There was a problem hiding this comment.
Looks good to me, aside from a couple of minor suggestions.
Changes
Outdated
| (Nicolás Ojeda Bär, review by Damien Doligez) | ||
|
|
||
| * #10896: Remove Stream, Genlex and Pervasives. Also remove legacy bigarray | ||
| library. |
There was a problem hiding this comment.
Is it worth mentioning here that the Bigarray module is now included in the distribution, and that this only refers to the bigarray ocamlfind library? It's a little confusing potentially since the previous sentence refers to modules.
There was a problem hiding this comment.
Thanks, reworded for clarity.
configure.ac
Outdated
| [AS_HELP_STRING([--disable-bigarray-lib], | ||
| [do not build the legacy separate bigarray library])]) | ||
| AC_ARG_ENABLE([bigarray-lib], [], | ||
| [AC_MSG_ERROR([The bigarray-lib option was deleted in OCaml 5.00.])], |
There was a problem hiding this comment.
| [AC_MSG_ERROR([The bigarray-lib option was deleted in OCaml 5.00.])], | |
| [AC_MSG_ERROR([The bigarray-lib option was deleted in OCaml 5.00, as it is now part of the standard library])], |
(to make OS porters live's easier)
There was a problem hiding this comment.
Thanks, reworded to clarify the sentence.
|
A note to check (just as I've been looking at base packages elsewhere) that we need to determine if OCaml 5.00 should be installing the base-bigarray opam package or not (I'm not certain without checking what the precise expectation of packages which depend on that is in opam-repository). |
7694e27 to
e3306f3
Compare
|
This is ready from my side, and already has one official approval, so am planning to merge this soon (either today or tomorrow) to have a maximum amount of time to investigate breakage in the ecosystem. |
|
RIP |
What it says on the tin. Note that
StreamandGenlexare available as an external library https://github.com/ocaml/camlp-streams.