Merged
Conversation
mrmr1993
suggested changes
Nov 22, 2021
| | Mprivate k -> | ||
| match priv with | ||
| | Public -> | ||
| link_kind ~inside:k field_public; |
Contributor
There was a problem hiding this comment.
This can raise an Invalid_argument exception inside link_kind if the same method is added multiple times. For example, this crashes the toplevel
class foo =
object
method private f (b : bool) = b
inherit object
method f (b : bool) = b
end
end;;
This was referenced Dec 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10781 by updating the associated
row_fieldwhen a private method is overridden with a public method. This requires tracking theserow_fields incsig_meths.