Closed
Conversation
Contributor
Author
|
Sorry, this is the wrong fix. By the way I am trying to fix the following warnings (observed in OS X and also in the RISC-V CI at least): |
Member
|
My solution to please both check-typo and the undefined Makefile variable warning was to define a separate upper function: |
Member
|
A variant of this works: --- a/stdlib/StdlibModules
+++ b/stdlib/StdlibModules
@@ -47,6 +47,9 @@ STDLIB_PREFIXED_MODULES=\
# add stdlib__ as prefix to a module except for internal modules
# and the stdlib module itself
+EMPTY=
+SPACE=$(EMPTY) $(EMPTY)
+$(SPACE) :=
define add_stdlib_prefix
$(or $(filter-out $(STDLIB_PREFIXED_MODULES), $1), \
stdlib__$(shell echo $1 | cut -c1 | tr '[:lower:]' '[:upper:]')$\More shortly... |
Contributor
|
I think the `EMPTY` variable is already defined in the build system
so it may not be necessary to define it again here. Perhaps the SPACE
variable can also be defined globally if used in more than one place.
|
Member
|
Ack - just testing an alternate fix |
Contributor
Author
|
Closing this in favor of #10270 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #10169 (I think)