Autoconf discoverability fixes#10186
Merged
shindere merged 3 commits intoocaml:trunkfrom Feb 10, 2021
Merged
Conversation
shindere
approved these changes
Feb 1, 2021
Contributor
|
Yeah, the change look correct to me, thanks.
|
b9be286 to
fb14a70
Compare
Contributor
Author
|
In a private exchange @shindere asked me to double-check if the headers used in configure were used in the code, and it turns out I had used for detecting |
This is required for configure to pass correct link flags in its tests, otherwise linking fails. This doesn't change anything for the MSVC build. Configure doesn't support it, and emits Gcc build flags that MSVC ignores.
fb14a70 to
9675963
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
AC_SEARCH_LIBSto discover network functions when they're not in libc. That way, autoconf passes the correct link flags to link with the libraries.Use correct headers and link flags with mingw-w64 to discover network functions and types.