Skip to content

ocamlbuild, improve _tags parsing and error report #6087

@vicuna

Description

@vicuna

Original bug ID: 6087
Reporter: @dbuenzli
Assigned to: @gasche
Status: closed (set by @xavierleroy on 2016-12-07T10:34:32Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.00.0
Target version: 4.02.0+dev
Category: -for ocamlbuild use https://github.com/ocaml/ocamlbuild/issues
Tags: junior_job
Related to: #4598 #5212 #6518
Monitored by: meyer @gasche @dbuenzli

Bug description

Great to see there are people willing to improve ocamlbuild !

So here are a few things:

  1. The following _tags file works:

true : package(gg),
package(vg)

  1. But not the following one:

true :
package(gg), package(vg)

  1. Neither the following one:

true
: package(gg), package(vg)

Could we

a)
Either be more consistant in the \ treatement or even better, avoid it altogether (I don't know if it would render the grammar ambiguous)

b)
Have a gnu-style error messages (http://www.gnu.org/prep/standards/standards.html#Errors)
so that we can easily jump to the location of the error from our editors. This is what is currently reported:

Lexical analysis error: _tags: Bad key in configuration line at line 1 (from file: "_tags")

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions