locate: Restore behavior of 413 branch with regard to module packs#1456
Closed
voodoos wants to merge 5 commits intoocaml:masterfrom
Closed
locate: Restore behavior of 413 branch with regard to module packs#1456voodoos wants to merge 5 commits intoocaml:masterfrom
voodoos wants to merge 5 commits intoocaml:masterfrom
Conversation
4391ea6 to
c32fbd6
Compare
trefis
reviewed
Apr 12, 2022
Collaborator
Author
Yes |
dffb0a5 to
fa79376
Compare
Restore usage of `cmt_path` Don't use move_to when reducing shapes Remove unused `Context.inspect` call Co-authored-by: trefis <thomas.refis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enabling the warnings highlighted a few weird things in the new implementation for locate.
This PR fixes these and restore some support for packs (it is still a bit broken, as it was with the previous implementation).