Merged
Conversation
Collaborator
emillon
commented
Feb 5, 2024
- test: add repro for dune subst crashes on large files (32-bit systems) #9538 (subst on 32-bit) (test: add repro for #9538 (subst on 32-bit) #9539)
- fix(subst): ignore large files (fix(subst): skip large files on 32-bit #9811)
Signed-off-by: Etienne Millon <me@emillon.org>
`Io.read_all` and related functions read the contents of a file in a string, which has a size limit (`Sys.max_string_length`) and can be an issue in 32-bit systems. This makes an explicit check and raises a `Code_error` in these situations. Signed-off-by: Etienne Millon <me@emillon.org>
Fixes ocaml#9538 This logs a warning for large files (>16MB on 32-bit systems). Signed-off-by: Etienne Millon <me@emillon.org>
d0468b3 to
0d431df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.