compatibility with ocaml PR#1569 (changes to compiler install dir)#966
Closed
v-gb wants to merge 1 commit intoocaml:mainfrom
v-gb:compat-ocaml-pr-1569
Closed
compatibility with ocaml PR#1569 (changes to compiler install dir)#966v-gb wants to merge 1 commit intoocaml:mainfrom v-gb:compat-ocaml-pr-1569
v-gb wants to merge 1 commit intoocaml:mainfrom
v-gb:compat-ocaml-pr-1569
Conversation
ghost
suggested changes
Jul 7, 2018
| ] | ||
| @ (if sep_libraries then [] else [ directory "+compiler-libs" ]) | ||
| @ | ||
| [ sub "common" [] |
There was a problem hiding this comment.
ocamlcommon is not in a sub-directory as well?
Contributor
Author
There was a problem hiding this comment.
It is, I guessed I missed this change and for some reason, it didn't break anything.
src/meta.ml
Outdated
| let builtins ~stdlib_dir = | ||
| let version = version "[distributed with Ocaml]" in | ||
| let sep_libraries = | ||
| List.exists (fun suf -> |
There was a problem hiding this comment.
the label is missing (that's what causing the CI failures)
Contributor
Author
There was a problem hiding this comment.
Hum, weird I was not getting this earlier but instead I had warning 32 in usexp.mli. Not sure what happened but I fixed this.
Signed-off-by: Valentin Gatien-Baron <valentin.gatienbaron@gmail.com>
ghost
approved these changes
Jul 8, 2018
|
Thanks. We'll merge this PR as soon as the OCaml PR is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See description of ocaml/ocaml#1569 .