Added rudimentary check on package names in dependencies#9385
Added rudimentary check on package names in dependencies#9385ElectreAAS wants to merge 0 commit intoocaml:mainfrom
Conversation
Leonidas-from-XIV
left a comment
There was a problem hiding this comment.
Great to have your first PR! I've added a few comments, convenient that there are already some cram tests to test the change.
|
Note: I only added the 'opam compatible' check in the |
|
@ElectreAAS We use |
|
I just rebased the PR on main, sorry for the noise. I have updated the expect part of test/blackbox-tests/test-cases/pkg/invalid-version.t, but not the text yet, as I'm quite confused as to what is the difference in tested behaviour in this test and test/blackbox-tests/test-cases/invalid-package-version.t. |
|
The two tests are slightly different:
|
|
However should we care about Not sure how many packages specify depends without generating opam files, because without it it is fairly pointless at the moment. |
Resolves #9270.
This PR adds a simple check to all the
<pkgname>listed in the dependencies of adune-project.I just saw #9371, and have no opinions on it, but since they look closely related, I'm linking it here too.
Pinging @Leonidas-from-XIV & @emillon for a review.