test: reproduction case for #9365#9366
Conversation
|
I have a fix ready after we merge this. |
b5ff009 to
4ecc9a7
Compare
|
If the issue is about the test stanza, why does the test include library and executable stanzas? Shouldn't it be possible to reproduce the issue only with the test stanza? |
|
@rgrinberg It's just about the test stanza, but this ensures we are also testing the library and executable stanzas. |
|
Don't we have other select tests that make this redundant? |
|
I could only find a test for executable, this additionally has a test for library. If you like, I can reduce this test down to test and add an additional library test. (Although I think it makes more sense to test them in one place). |
|
It would be better not to mix adding a regression test and re-organizing the existing tests. So I suggest that you a regression test and then create a subsequent PR to re-organize things. |
We also test the other stanzas while reproducing the bug with the test stanza. Signed-off-by: Ali Caglayan <alizter@gmail.com>
4ecc9a7 to
38800da
Compare
|
I've reduced the test down to testing only the bugged behaviour of |
|
By the way, there might a similar bug with |
|
Thanks. Next time, try to keep the test demonstrating the bug as simple as possible. Improvements can always be made later. |
We also test the other stanzas while reproducing the bug with the test stanza.