fix(fsevents): correct test output#9289
Merged
rgrinberg merged 1 commit intoocaml:mainfrom Nov 26, 2023
kevinji:fix-fsevents-tests
Merged
fix(fsevents): correct test output#9289rgrinberg merged 1 commit intoocaml:mainfrom kevinji:fix-fsevents-tests
rgrinberg merged 1 commit intoocaml:mainfrom
kevinji:fix-fsevents-tests
Conversation
The new output matches the behavior in a subsequent PR when the segfaults are fixed, and makes more sense with relation to the comments in the tests. Signed-off-by: Kevin Ji <1146876+kevinji@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new output matches the behavior in a subsequent PR when the segfaults are fixed, and makes more sense with relation to the comments in the tests.
This pulls out some of the changes from #9009 to make that PR more readable. Unfortunately, these tests cannot be run without the changes in that PR as the Dune process segfaults when running these tests.