Skip to content

test: duplicate rules being loaded on rebuild#9213

Merged
rgrinberg merged 2 commits intoocaml:mainfrom
Alizter:ps/branch/test__duplicate_rules_being_loaded_on_rebuild
Nov 17, 2023
Merged

test: duplicate rules being loaded on rebuild#9213
rgrinberg merged 2 commits intoocaml:mainfrom
Alizter:ps/branch/test__duplicate_rules_being_loaded_on_rebuild

Conversation

@Alizter
Copy link
Copy Markdown
Collaborator

@Alizter Alizter commented Nov 17, 2023

Here is a minimal test case for a bug that occurs when using watch mode.

@emillon I would suggest that this is blocking for 3.12 as it renders watch mode unusable.

@Alizter Alizter marked this pull request as ready for review November 17, 2023 18:04
Signed-off-by: Ali Caglayan <alizter@gmail.com>
@Alizter Alizter force-pushed the ps/branch/test__duplicate_rules_being_loaded_on_rebuild branch from 61721e3 to 6ffc94a Compare November 17, 2023 18:13
@Alizter
Copy link
Copy Markdown
Collaborator Author

Alizter commented Nov 17, 2023

I managed to bisect this to 1878979 from #9160.

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
@rgrinberg rgrinberg merged commit d6023b5 into ocaml:main Nov 17, 2023
@rgrinberg
Copy link
Copy Markdown
Member

Thanks for the repro

@Alizter Alizter deleted the ps/branch/test__duplicate_rules_being_loaded_on_rebuild branch November 17, 2023 20:38
@emillon
Copy link
Copy Markdown
Collaborator

emillon commented Nov 20, 2023

I would suggest that this is blocking for 3.12 as it renders watch mode unusable.

No problem for these kinds of fixes since you've identified it as a regression.
Though in the future I would recommend opening a separate issue for the problem itself. Here we have the bug report, the repro and the fix in the same PR, which is harder to work with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants