test: serialize and deserialize RPC error messages#8411
Merged
rgrinberg merged 3 commits intoocaml:mainfrom Aug 26, 2023
Merged
Conversation
Collaborator
Author
|
@rgrinberg I think the correct fix for this would be to make |
rgrinberg
reviewed
Aug 17, 2023
rgrinberg
reviewed
Aug 17, 2023
63281ae to
8f9d38f
Compare
8f9d38f to
2b46350
Compare
692876c to
bac10c3
Compare
Collaborator
Author
|
@rgrinberg I've pushed another test which shows how location printing is kind of funny. I need some help scrubbing the output however. |
bac10c3 to
b55b2e5
Compare
Alizter
commented
Aug 23, 2023
Alizter
commented
Aug 23, 2023
b55b2e5 to
fd58a5d
Compare
rgrinberg
reviewed
Aug 24, 2023
fd58a5d to
4c93ceb
Compare
Alizter
commented
Aug 24, 2023
Collaborator
Author
|
@rgrinberg I've also included dyn serialisation so we can more finely compare the Pp structure that has been serialised. |
rgrinberg
reviewed
Aug 24, 2023
4c93ceb to
77ce937
Compare
Collaborator
Author
|
@rgrinberg I've moved the tests now and added yet another example of an error message that changes. All these examples will be fixed by my upcoming PR. |
a74d86f to
8c09cc7
Compare
rgrinberg
reviewed
Aug 24, 2023
We demonstrate a bug with how error messages are serialized. Currently there are two "Error:" prefixes after serializing and deserializing. This is because the prefix hasn't been stripped in the initial serialization. We should strip the prefix since the severity information is recorded elsewhere in the diagnostic data. Signed-off-by: Ali Caglayan <alizter@gmail.com>
8c09cc7 to
3c924a3
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We demonstrate a bug with how error messages are serialized. Currently there are two "Error:" prefixes after serializing and deserializing. This is because the prefix hasn't been stripped in the initial serialization. We should strip the prefix since the severity information is recorded elsewhere in the diagnostic data.