Merged
Conversation
75510c1 to
effe603
Compare
rgrinberg
reviewed
Aug 16, 2023
1c7a9c4 to
ae176ca
Compare
rgrinberg
reviewed
Aug 17, 2023
rgrinberg
reviewed
Aug 17, 2023
ae176ca to
f860245
Compare
rgrinberg
reviewed
Aug 17, 2023
This demonstrates that RPC jobs events are not stopped when dune is interrupted and restarted. Signed-off-by: Ali Caglayan <alizter@gmail.com>
f860245 to
18d4ff3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This demonstrates that RPC jobs events are not stopped when dune is interrupted and restarted.
cc @rgrinberg
I can move this test somewhere else if needed.
I can also confirm that this is fixed by #8409