Skip to content

fix: update digest and incremental db versions#8198

Merged
rgrinberg merged 1 commit intomainfrom
ps/rr/fix__update_digest_and_incremental_db_versions
Jul 14, 2023
Merged

fix: update digest and incremental db versions#8198
rgrinberg merged 1 commit intomainfrom
ps/rr/fix__update_digest_and_incremental_db_versions

Conversation

@rgrinberg
Copy link
Copy Markdown
Member

@rgrinberg rgrinberg commented Jul 13, 2023

#8052 updated the representation for
these, but didn't bump the version.

Signed-off-by: Rudi Grinberg me@rgrinberg.com

@rgrinberg
fix: update digest and incremental db versions
50a68ec 
#8052 updated the representation for
these, but didn't bump the version.

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

<!-- ps-id: 72ce4eb6-2623-4c8e-9933-92a9209f25d1 -->
@rgrinberg rgrinberg requested a review from snowleopard July 13, 2023 08:27
@ocaml-benchmarks
Copy link
Copy Markdown

ocaml-benchmarks bot commented Jul 13, 2023

#8198 (50a68ec) changes the metrics as follows in comparison to main (a0145b2) when running on fermat (bench/monorepo/bench.Dockerfile):

Benchmark: default

Test: dune monorepo benchmarks

  • build from scratch changed by 1.9%
  • null build changed by 11.2%
  • watch mode: changing file in 'base' library changed by -1.5%
  • watch mode: changing file in 'file_path' library changed by -0.1%
  • watch mode: fixing error in file in 'base' library changed by -0.9%
  • watch mode: fixing error in file in 'file_path' library changed by -1.0%
  • watch mode: introducing error in file in 'base' library changed by 8.0%
  • watch mode: introducing error in file in 'file_path' library changed by -8.9%

snowleopard
snowleopard approved these changes Jul 13, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@snowleopard snowleopard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks. Did you find it because the change broke something?

@Alizter
Copy link
Copy Markdown
Collaborator

Alizter commented Jul 13, 2023

I got a few segfaults that disappeared after cleaning today, but I was tweaking rpc yesterday too so it might be unrelated.

@snowleopard
Copy link
Copy Markdown
Collaborator

snowleopard commented Jul 13, 2023

I got a few segfaults that disappeared after cleaning today, but I was tweaking rpc yesterday too so it might be unrelated.

@Alizter I see, thanks!

@rgrinberg Could you also add a test to prevent such breakage in future? We should basically make the format change observable somewhere, forcing us to update the version when needed.

@rgrinberg
Copy link
Copy Markdown
Member Author

rgrinberg commented Jul 14, 2023

Could you also add a test to prevent such breakage in future? We should basically make the format change observable somewhere, forcing us to update the version when needed.

Coming up soon

@rgrinberg rgrinberg merged commit 329ba3d into main Jul 14, 2023
@rgrinberg rgrinberg deleted the ps/rr/fix__update_digest_and_incremental_db_versions branch July 14, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snowleopard snowleopard snowleopard approved these changes

@Alizter Alizter Alizter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rgrinberg @Alizter @snowleopard