Skip to content

refactor: cleanup unused imports#8192

Merged
rgrinberg merged 1 commit intoocaml:mainfrom
Alizter:ps/branch/refactor__cleanup_unused_imports
Jul 12, 2023
Merged

refactor: cleanup unused imports#8192
rgrinberg merged 1 commit intoocaml:mainfrom
Alizter:ps/branch/refactor__cleanup_unused_imports

Conversation

@Alizter
Copy link
Copy Markdown
Collaborator

@Alizter Alizter commented Jul 12, 2023

No description provided.

Signed-off-by: Ali Caglayan <alizter@gmail.com>
@Alizter Alizter requested a review from rgrinberg July 12, 2023 13:31
@Alizter Alizter mentioned this pull request Jul 12, 2023
12 tasks
Copy link
Copy Markdown
Collaborator

@Leonidas-from-XIV Leonidas-from-XIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too bad there is no compiler warning about unused modules that we could turn on.

@ocaml-benchmarks
Copy link
Copy Markdown

#8192 (c6dd6ad) changes the metrics as follows in comparison to main (4256431) when running on fermat (bench/monorepo/bench.Dockerfile):

Benchmark: default

Test: dune monorepo benchmarks

  • build from scratch changed by 3.6%
  • null build changed by -1.7%
  • watch mode: changing file in 'base' library changed by 2.7%
  • watch mode: changing file in 'file_path' library changed by 1.5%
  • watch mode: fixing error in file in 'base' library changed by -0.6%
  • watch mode: fixing error in file in 'file_path' library changed by -0.1%
  • watch mode: introducing error in file in 'base' library changed by -18.9%
  • watch mode: introducing error in file in 'file_path' library changed by -6.4%

@rgrinberg rgrinberg merged commit 52c1f28 into ocaml:main Jul 12, 2023
@Alizter Alizter deleted the ps/branch/refactor__cleanup_unused_imports branch December 22, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants