Skip to content

rpc: improve error message#8191

Merged
rgrinberg merged 1 commit intoocaml:mainfrom
Alizter:ps/branch/rpc__improve_error_message
Jul 12, 2023
Merged

rpc: improve error message#8191
rgrinberg merged 1 commit intoocaml:mainfrom
Alizter:ps/branch/rpc__improve_error_message

Conversation

@Alizter
Copy link
Copy Markdown
Collaborator

@Alizter Alizter commented Jul 12, 2023 •
edited
Loading

Make the error message a bit nicer.

@Alizter
rpc: improve error message
52dbcc6 
Signed-off-by: Ali Caglayan <alizter@gmail.com>
@Alizter Alizter requested a review from rgrinberg July 12, 2023 13:26
@Alizter Alizter mentioned this pull request Jul 12, 2023
Merged
12 tasks
@ocaml-benchmarks
Copy link
Copy Markdown

ocaml-benchmarks bot commented Jul 12, 2023

#8191 (52dbcc6) changes the metrics as follows in comparison to main (4256431) when running on fermat (bench/monorepo/bench.Dockerfile):

Benchmark: default

Test: dune monorepo benchmarks

  • build from scratch changed by 5.2%
  • null build changed by -1.7%
  • watch mode: changing file in 'base' library changed by 1.6%
  • watch mode: changing file in 'file_path' library changed by 2.4%
  • watch mode: fixing error in file in 'base' library changed by -1.1%
  • watch mode: fixing error in file in 'file_path' library changed by 1.7%
  • watch mode: introducing error in file in 'base' library changed by -9.5%
  • watch mode: introducing error in file in 'file_path' library changed by -0.1%

@rgrinberg rgrinberg merged commit 32c68c2 into ocaml:main Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgrinberg rgrinberg Awaiting requested review from rgrinberg

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Alizter @rgrinberg