Merged
Conversation
Alizter
previously approved these changes
May 1, 2023
8b1a1b2 to
afe3b45
Compare
afe3b45 to
e7c8a14
Compare
Alizter
approved these changes
May 1, 2023
Collaborator
Alizter
left a comment
There was a problem hiding this comment.
Resizing now renders reliably.
Member
Author
|
ping @snowleopard |
snowleopard
reviewed
May 19, 2023
snowleopard
reviewed
May 19, 2023
snowleopard
approved these changes
May 19, 2023
Collaborator
snowleopard
left a comment
There was a problem hiding this comment.
Looks good but I left a couple of comments.
Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: 1e29eae2-40a1-4f0e-8ea1-81418eec9b72 -->
e7c8a14 to
92d40ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the tui to be rerendered on resize events. This change is twofold:
Adding @snowleopard as a reviewer for the insignificant changes to scheduler to allow us to handle sigwinch.